Using GITHUB_TOKEN to setup auth for extensions

[kohlivarun5]

I see that there is support for GITHUB_TOKEN to be passed in via the env, and tests here seem to suggest that with that, user should not need to log-in again.

In my environment, when I try this, the extension asks to sign-in and routes to Github for auth

1. Anything that I might be missing here ? I should mention, I am trying this against an enterprise instance, by setting "github-enterprise.uri" in code-server settings.json
2. Is there a way to make it even more seamless, so that the user does not have to click Sign-In & Allow ? Ideally, we would be able to set it up such that the extension just works as pre-authorized

Info about code-server

code-server: v4.17.1
Code: 1.82.2
Commit: 2eba7af117ea58d45a6c6449ee4fe63c8d4d53aa
Date: 2023-09-29T21:59:34.461Z
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.0 Safari/605.1.15

[kohlivarun5]

@code-asher Is this working as expected, or might I be missing some setup ?

[code-asher]

Hmm or maybe it is related to the enterprise URL. That is not something I have tested. If it works in desktop VS Code it should work in code-server though.

[kohlivarun5]

Thanks for the pointer, will test desktop VSCode to confirm behavior

[benz0li]

@code-asher This does not work as stated. Instead of

// It should ask to select an account, one of which will be the one we
// pre-injected.

one has to sign in to GitHub:

$ code-server --version
4.18.0 d7a2b4936af1bfd80cb96f2567af68badc2325e3 with Code 1.83.1

---

I found out, that [compared to Codespaces] environment variable GITHUB_TOKEN is unset in the code-server Terminal – even though being set before starting code-server.
👉 Environment variable CODE_SERVER_VERSION – even though being set in the Dockerfiles of my JupyterLab language docker-stacks – is also unset in the code-server Terminal.

[benz0li]

Regular usage of the 'GitHub Pull Requests and Issues' extensions, i.e. after properly signing into GiHub, seems to work fine since code-server v4.17.1.
ℹ️ Until the cache (website data) of the browser is cleared, of course.

code-server v4.16.1 (and maybe earlier versions) behaved slightly different: When setting environment variable GITHUB_TOKEN, 'Accounts' (Activity Bar) showed you as signed into GitHub as soon as a folder containing a GitHub repository was opened.
👉 This is not the case anymore.

For me, being more of a GitLab user, all this is nice to have and not mandatory.

[code-asher]

Ahh OK thank you for the report. It might be a bug with VS Code's --github-auth, all we do now is set that to the value in the environment variable or flag, but we will need to investigate further.