Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iPad: Korean input isn't combined properly #1314

Closed
nhooyr opened this issue Jan 29, 2020 · 7 comments
Closed

iPad: Korean input isn't combined properly #1314

nhooyr opened this issue Jan 29, 2020 · 7 comments
Assignees
@jsjoeio
Labels
browser-safari Safari related os-ios iOS/iPad related upstream Needs to be fixed upstream

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Jan 29, 2020

See #1277
@nhooyr nhooyr added the upstream Needs to be fixed upstream label Jan 29, 2020
@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 29, 2020

Only happens on iPad, works fine on my Mac.

@nhooyr nhooyr added the iPad label Apr 17, 2020
@nhooyr nhooyr added browser-safari Safari related and removed browser-mobile-safari labels Dec 8, 2020
@rightones
Copy link

Any updates here?

@code-asher
Copy link
Member

code-asher commented Jan 11, 2021 via email

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 11, 2021

@code-asher I will take this on and check

@jsjoeio jsjoeio self-assigned this Jan 11, 2021
@nhooyr nhooyr added the os-ios iOS/iPad related label Jan 18, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 19, 2021 •
edited
Loading

I was able to reproduce on code-server.

Reproduce

  1. Add Korean keyboard under General > Keyboard > Keyboards > Add New Keyboard > Korean
  2. Open code-server
  3. Open file (e.g. markdown file)
  4. Switch to Korean keyboard
  5. Start typing: ㄱㅏ

Expected

가

2021-01-19 16 01 24

Actual

ㄱ가

IMG_0125.MP4

Next steps

  • reproduce in Codespaces to see if upstream

Successfully reproduced in Codespaces

IMG_0127.MP4

@jsjoeio jsjoeio mentioned this issue Jan 19, 2021
Closed
@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 20, 2021

Opened an issue upstream ^

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 20, 2021

Closing this since the issue has been captured upstream.

@jsjoeio jsjoeio closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
browser-safari Safari related os-ios iOS/iPad related upstream Needs to be fixed upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jsjoeio @nhooyr @rightones @code-asher