Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(README.md): add note regarding structure of CODER_IMAGE_PULL_SECRET #60

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jan 2, 2024

Adds a note about the required structure of .dockerconfigjson if you're generating it using external tooling.

@johnstcn johnstcn self-assigned this Jan 2, 2024
Copy link

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnstcn johnstcn force-pushed the cj/docs/image-pull-secret-note branch 2 times, most recently from 64997cb to cb7e3ec Compare January 2, 2024 13:00
@johnstcn johnstcn force-pushed the cj/docs/image-pull-secret-note branch from cb7e3ec to 977490b Compare January 2, 2024 13:04
@johnstcn johnstcn merged commit 3900eff into main Jan 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants