Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Go 1.22 compatibility #1

Closed
wants to merge 1 commit into from
Closed

chore: Go 1.22 compatibility #1

wants to merge 1 commit into from

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jan 2, 2024

Just need to remove an unnecessary !go1.22 build directive.

@aslilac
Copy link
Member Author

aslilac commented Jan 2, 2024

oh wow, we don't have any tests set up on this repo

@aslilac
Copy link
Member Author

aslilac commented Jan 3, 2024

and we stripped out the Makefile so that I can't make test 💀

@aslilac
Copy link
Member Author

aslilac commented Jan 3, 2024

Based on changes in this PR: google#9197

I'm not sure what to think about the .mapper.Mapper, because we're already on 1.21 and nothing is broken?

@aslilac
Copy link
Member Author

aslilac commented Jan 3, 2024

Related to coder/coder#11342

@mafredri
Copy link
Member

mafredri commented Jan 3, 2024

and we stripped out the Makefile so that I can't make test 💀

@aslilac that's because the forked branch is based on a synthetic branch (we didn't actually remove it):

This branch is a synthetic branch, containing only Go sources, that is compatible with standard Go tools. See the master branch for authoritative sources and tests.

If we want to set up testing, I believe we'll need to base that of the master branch (well, matching the cutoff point we're currently using) and then, perhaps, we'll also need to generate a synthesized branch ourselves.

Ultimately, I think our time would be better spent updating gvisor/tailscale instead of setting up our own testing environment for gvisor. At least for now.

@aslilac
Copy link
Member Author

aslilac commented Jan 3, 2024

Ultimately, I think our time would be better spent updating gvisor/tailscale

I agree, that's just way outside of my comfort zone, and I was trying to see if this was something I could patch in a day :p

@mafredri
Copy link
Member

mafredri commented Jan 3, 2024

@aslilac that's fair. And ultimately, if Coder builds and works with this change, I'd say that's good enough to :shipit:. To try it out you can add a replace directive in coder/coder/go.mod.

@coadler
Copy link
Member

coadler commented Jan 3, 2024

It looks like this might be a bit more complicated than just removing the build directive: google@f3e4a1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants