Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support keysAndArgs API of stdlib slog #173

Merged
merged 3 commits into from
May 23, 2023
Merged

Support keysAndArgs API of stdlib slog #173

merged 3 commits into from
May 23, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented May 16, 2023

This will simplify our eventual transition towards std slog.

@github-actions
Copy link

Pull Request Test Coverage Report for Build eb91852f26f9df881d79e08a91236e2facf06b4d-PR-173

  • 28 of 31 (90.32%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 96.875%
Changes Missing Coverage Covered Lines Changed/Added Lines %
slog.go 23 26 88.46%
Totals Coverage Status
Change from base Build 4d60f86d6ad42e23788d137ed201c6527742a289: -0.3%
Covered Lines: 744
Relevant Lines: 768
💛 - Coveralls

@ammario ammario requested review from kylecarbs, Emyrk and coadler and removed request for kylecarbs and Emyrk May 20, 2023 01:42
@ammario ammario merged commit c17dfd2 into main May 23, 2023
@ammario ammario deleted the kvapi branch May 23, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammario @coadler