Justify slog's existence #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
changed the title
nhooyr
force-pushed
the
why
branch
2 times, most recently
from
ecdcf59
to
845b030
Compare
coadler
reviewed
Dec 3, 2019
README.md
Outdated
| We wanted an API that only accepted the equivalent of [zap.Any](https://godoc.org/go.uber.org/zap#Any) for every field. | ||
| This is [slog.F](https://godoc.org/cdr.dev/slog#F). | ||
|
|
||
| Second, we found the human readable format to be hard to read due to the lack appropriate colors for different levels |
There was a problem hiding this comment.
Suggested change
| Second, we found the human readable format to be hard to read due to the lack appropriate colors for different levels | |
| Second, we found the human readable format to be hard to read due to the lack of appropriate colors for different levels |
README.md
Outdated
| instead. We wanted it to be automatic, even for private fields. slog handles this transparently for us. It will automatically | ||
| log Go structures with their fields separate, including private fields. | ||
|
|
||
| Seventh, t.Helper style APIf |
There was a problem hiding this comment.
Suggested change
| Seventh, t.Helper style APIf | |
| Seventh, t.Helper style API |
README.md
Outdated
|
|
||
| Seventh, t.Helper style APIf | ||
|
|
||
| Eight, tighter integration with `*testing.T`. |
There was a problem hiding this comment.
Suggested change
| Eight, tighter integration with `*testing.T`. | |
| Eighth, tighter integration with `*testing.T`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Closes #34