-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Allow insecure" option does not work #151
Comments
I tried to reproduce and the insecure option now works for me. Maybe something was fixed upstream? |
I thought it could be related to the proxy support setting, but I have it set to Issues like microsoft/vscode#173314 and my own examination of the code certainly seem to indicate that setting The |
(Discord thread) Info
ScreenshotsWorkaroundThe problem seems to be fixed by setting the |
VS Code:
Coder extension version: 1.3.2 Nginx.conf:
|
Does changing |
Haven't tried it. I could try it and come back to you. I event tried selecting the ca certs but this had no impact either. |
Please do! VS Code overrides our proxy agent (where we set As for the certificates, if you have access to it you might want to try the |
I tried the coder: tls ca certificate but had no impact. |
This had no impact either |
Thank you for trying. It is strange, we set |
Or...maybe something to do with Axios? |
Did some more digging, I think |
One more comment: I am surprised the CA option did not work. Are you pointing it to the full chain or just part of it? |
I had a call with the person in my company that generates the certs. We went through it and used the whole bundle, unfortunately there was no difference. Is there a way to get more debugging or verbose for the extension when it tries to login? |
Sorry for the delayed response. "Unable to verify the first certificate" is all the debugging information we get from Node unfortunately, but Node does have an debug environment variable that might tell us more. For example: You may also want to try setting |
Thank you for the answer @code-asher . Will give them a try tomorrow and will get back to you |
Unfortunately no luck with any of those. I set the node_debug as env variable for my user in windows but I couldn't get more logs during the error. |
Sorry about that, I should have tested it first. I guess I know you went through the certificate with someone already, but could you double-check by running this from the same machine VS Code is on? (You may have already ran something like this.)
You should see all the expected certs without any errors. Also, using something like https://www.ssllabs.com/ssltest/ to test the domain could be helpful, if it is public. And you probably already tried this as well, but does I hope to find some time to test your NGINX configuration with a self-signed certificate chain soon, there could very well be a bug in the plugin or some setting we are not configuring correctly. I know this issue is actually about the insecure option not working though; I am still not sure why it seems to not be working in this case, but I will try to debug further if I am able to reproduce. |
For some reason, when we set this inside VS Code, it just does nothing. It works in tests so the code is correct, but maybe VS Code does some shenanigans with the http/s modules?
The text was updated successfully, but these errors were encountered: