accept: Add unwrapping for hijack like http.ResponseController #472
+110
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
force-pushed
the
mafredri/support-http-responsecontroller
branch
from
ea6952a
to
d86cd75
Compare
mafredri
changed the title
http.ResponseController instead of http.Hijacker assertion
mafredri
force-pushed
the
mafredri/support-http-responsecontroller
branch
from
d86cd75
to
558c496
Compare
Since we rely on the connection not being hijacked too early (i.e. detecting the presence of http.Hijacker) to set headers, we must manually implement the unwrapping of the http.ResponseController. By doing so, we also retain Go 1.19 compatibility without build tags. Closes #455
mafredri
force-pushed
the
mafredri/support-http-responsecontroller
branch
2 times, most recently
from
230a06c
to
f86e67b
Compare
mafredri
force-pushed
the
mafredri/support-http-responsecontroller
branch
from
f86e67b
to
ee7b9af
Compare
mafredri
changed the title
mafredri
changed the title
mafredri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we rely on the connection not being hijacked too early (i.e. detecting the presence of http.Hijacker) to set headers, we must manually implement the unwrapping of the http.ResponseController. By doing so, we also retain Go 1.19 compatibility without build tags (still used in compat test, though).
Closes #455