Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes:[T348600] Title not being shown and placeholder text is getting cut #219

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fixes:[T348600] Title not being shown and placeholder text is getting cut #219

merged 2 commits into from
Oct 13, 2023

Conversation

okerekechinweotito
Copy link
Contributor

@okerekechinweotito okerekechinweotito commented Oct 11, 2023 •
edited
Loading

Fixes: T348600

Proposed Changes

  • The title/identifier should be displayed properly.
  • The placeholder text should say "Enter valid identifier"
  • The validation should accept either Alphabets, Numbers, or Alphanumeric characters
  • Restructure and Move Identifier validation into server.js

Files Created/Updated

  • components/Books.js - receive isInValidIdentifier response from server and implement frontend. Update the changeIdentifier placeholder
  • server.js - validate identifier and return isInValidIdentifier: true if validation fails

Current Look

Screenshot (40)

Checklist

  • Coding Conventions are followed.
  • Comments are used for Documenting the Code.
  • Correct File Names are mentioned.

coderwassananmol
coderwassananmol reviewed Oct 12, 2023
View reviewed changes
server.js Outdated Show resolved Hide resolved
coderwassananmol
coderwassananmol reviewed Oct 12, 2023
View reviewed changes
server.js Outdated Show resolved Hide resolved
coderwassananmol
coderwassananmol requested changes Oct 12, 2023
View reviewed changes
Copy link
Owner

@coderwassananmol coderwassananmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the changes.

@okerekechinweotito
Copy link
Contributor Author

@coderwassananmol Bugs fixed

@coderwassananmol coderwassananmol merged commit 80898ac into coderwassananmol:develop Oct 13, 2023
@coderwassananmol coderwassananmol mentioned this pull request Oct 13, 2023
Closed
@Parthiv-M Parthiv-M mentioned this pull request Oct 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderwassananmol coderwassananmol coderwassananmol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okerekechinweotito @coderwassananmol