Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to TypeScript version 3.4 #1683

Closed
hasparus opened this issue Apr 1, 2019 · 0 comments · Fixed by #1843
Closed

Upgrade to TypeScript version 3.4 #1683

hasparus opened this issue Apr 1, 2019 · 0 comments · Fixed by #1843
Labels
🎒 Bundler Refers to CodeSandbox's In-Browser Bundler 🤔 Improvement

Comments

@hasparus
Copy link
Contributor

hasparus commented Apr 1, 2019

TS 3.4 adds new syntax (const contexts and readonly tuples) which isn't supported now. Repro on CodeSandbox

Could be solved with #942 but this is smaller scope, so I've created separate issue.
@lbogdan lbogdan added 🤔 Improvement 🎒 Bundler Refers to CodeSandbox's In-Browser Bundler labels Apr 1, 2019
@ksaldana1 ksaldana1 mentioned this issue Apr 13, 2019
Closed
CompuIves added a commit that referenced this issue May 4, 2019
@CompuIves
Support dynamic typescript version from package.json
496b15c 
Fixes #942
Fixes #1683
@CompuIves CompuIves mentioned this issue May 4, 2019
Merged
CompuIves added a commit that referenced this issue May 4, 2019
@CompuIves
Support dynamic typescript version from package.json (#1843)
b73db70 
* Support dynamic typescript version from package.json

Fixes #942
Fixes #1683

* Fix typings

* Fix typings

* Allow for extension of package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎒 Bundler Refers to CodeSandbox's In-Browser Bundler 🤔 Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support dynamic typescript version from package.json codesandbox/codesandbox-client
2 participants
@lbogdan @hasparus