Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add vendor prefix for file tab styling #1999

Merged
merged 1 commit into from
May 31, 2019

Conversation

jyash97
Copy link
Contributor

@jyash97 jyash97 commented May 31, 2019

What kind of change does this PR introduce?
Styling issue in firefox

What is the current behavior?
File tab on editor requires a firefox prefix for min-width
image

What is the new behavior?
image

What steps did you take to test this?

  • Checked the developer tools which was saying invalid property, than checked the browser compatibility over here
  • Tested it over localhost:3000 on both chrome and firefox

Checklist:

  • Documentation - N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table - N/A

Using CodeSandbox for more than a year. Really awesome work guys 💯

@SaraVieira
Copy link
Contributor

Hey!!

Thank you so much for yout help :)

This is awesome

@SaraVieira SaraVieira merged commit 8e1e79f into codesandbox:master May 31, 2019
@SaraVieira
Copy link
Contributor

@all-contributors bot please add @jyash97 for code

@allcontributors
Copy link
Contributor

@SaraVieira

I've put up a pull request to add @jyash97! 🎉

batiskafff pushed a commit to batiskafff/codesandbox-client that referenced this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants