-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore options 31 #32
Conversation
}); | ||
|
||
|
||
gulp.task('minify', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a minify
task because
- The extension code will be zipped up and delivered via Chrome Web Store
- The code is all open-source, so no need to obfuscate/minify/uglify it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on a 'publish' task to compile and pack the zip file. Minifying was to compress even more. Plus it's only the compiled js not the coffee src.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep the build/publish tasks as simple as possible: removing minify
task lets us remove 30 lines of gulp configuration and 3 dependencies.
When I ran |
There's no |
We should also add these files to
I also filed an issue to remove |
The only things I'd like to block the merge are:
The rest can be filed as issues or cleaned up in the course of other work. |
@@ -1 +1,3 @@ | |||
*.swp | |||
node_modules | |||
pkg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add .DS_Store
Superseded by #40 |
This is a start to #31. it allows the user to save a string in local storage. Next step sending the token with bid requests.