Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added drop down list of valid codesy domains to options page #8

Closed
wants to merge 7 commits into from
Closed

added drop down list of valid codesy domains to options page #8

wants to merge 7 commits into from

Conversation

jdungan
Copy link
Member

@jdungan jdungan commented Dec 15, 2013

This should close Issue#7.

@groovecoder
Copy link
Member

Nice! Can you squash the commits and maybe put "fix #7 - " at the front of the commit message?

@jdungan
added drop down list of valid codesy domains to options page
12ce972 
correct domain list . not -

bootstrapped options page

refactor form build

add codesy.js for api calls

Fix codesy#7,codesy#8,codesy#12  Added dropdown and bootstrap to options, jqueryfied the widget insertion, added codesy.js
@jdungan
Merge branch 'master' of https://github.com/jdungan/chrome-extension
8548e56 
Rebased commits
@jdungan
Copy link
Member Author

jdungan commented Dec 22, 2013

My first rebasing. Didn't get the fix msg to the top of the message. Sorry.

@groovecoder
Copy link
Member

Whoa, this does a lot more than just the drop-down in the options. It looks good, but I'll want to take a little time to review it all.

@groovecoder groovecoder mentioned this pull request Dec 22, 2013
Merged
@jdungan
Copy link
Member Author

jdungan commented Dec 22, 2013

Yeah. I started refactoring so that it will be easier to add features down the road.

On Dec 22, 2013, at 11:30 AM, luke crouch notifications@github.com wrote:

Whoa, this does a lot more than just the drop-down in the options. It looks good, but I'll want to take a little time to review it all.

—
Reply to this email directly or view it on GitHub.

@jdungan jdungan closed this Dec 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdungan @groovecoder