Changes for Jitsi UI #518
Changes for Jitsi UI #518
Conversation
|
LGTM! |
|
@jaskiratsingh2000 @vaibhavdaren A small concern from my end, Is this the suggested button format that we are planning to use within the other Modals used throughout the platform? |
Nope. It should match with other button designs |
There was a problem hiding this comment.
@nisarg1499 Please use the css classes which is used in all the other modals.
Just have a look at modals.scss.
You don't need to write css for this. Also for this part why you modified comments.scss ??
It would have effect the comment modals as well. Please look at it.
Actually the css of comment file was being used in join call button. But now I have updated the css of jitsi and now it's independent. And the design element is also same as others. |
|
Final UI. |
Looks fine now. |
* Implements markdown and priview functionality * Parsing content within comment * Comment notifications (#501) * Initial * Addition of comments section * requested changes * Changes for Jitsi UI (#518) * css changes for jitsi box ui change * edited jitsi.scss for jitsi ui and reverted changes of comment.scss * changes made for making same fonts * added modals in jitsi ui * removed unnecessary code from jitsi.scss * fixing dev branch issues (#525) * implemented user activity and fix inconsistencies (#527) * Settings integrate and deploy configuration (#530) * integrated settings page and user activity modification * configure to deploy * Insights (#529) * Adding reactGA * Insights section * removing /hompage path * Requested changes * initial changes * Fetching data from the backend and integrating redux * Fixing modal issues (#531) * social links fix (#545) * fix issues (#555) * Fixing proposal functionality issues (#553) Co-authored-by: Asel <peirisasel373@gmail.com> Co-authored-by: Nisarg Shah <nisshah1499@gmail.com> Co-authored-by: Rupesh Krishna Jha <rupeshiya@gmail.com>
Issue Solved : #516
Image of UI after changes
Allignment is done and height issue is also solved.
Please review : @jaskiratsingh2000 @vaibhavdaren