Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issues #555

Merged
merged 1 commit into from
Aug 6, 2020
Merged

fixed issues #555

merged 1 commit into from
Aug 6, 2020

Conversation

Rupeshiya
Copy link
Member

@Rupeshiya Rupeshiya commented Aug 3, 2020

PR contains fix for:
resolve #540
resolve #543
resolve #538
resolve #550
resolve #536
resolve #534
resolve #523

Fix

  • Signup/Login page
  • Invite link issue
  • Buttons issue
  • All date format fix

Screenshots:
1. Login/Signup scroll fix
image

2. Invite link fix:
GIF:
bandicam-2020-08-03-11-00-13-530

3. All date format fix:
image

image

image

4. Forgot password
bandicam-2020-08-03-11-58-39-498

@Rupeshiya
Copy link
Member Author

@ayushnagar123 @jaskiratsingh2000 Plz review

@Rupeshiya Rupeshiya force-pushed the login_page branch 2 times, most recently from 65adae0 to b3a88e2 Compare August 3, 2020 06:33
@ayushnagar123
Copy link
Member

ayushnagar123 commented Aug 3, 2020

Please fix the Event Card view issue. Rest of the issues seems to be resolved great work.
image

@Rupeshiya
Copy link
Member Author

Done @ayushnagar123
image

Copy link
Member

@ayushnagar123 ayushnagar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@jaskiratsingh2000
Copy link
Member

As I have mentioned previously that actual buttons should be used for social handles.

@Rupeshiya
Copy link
Member Author

As I have mentioned previously that actual buttons should be used for social handles.

@jaskiratsingh2000 That's fixed in #558
Please have a look

@vaibhavdaren vaibhavdaren merged commit 8b3ac65 into codeuino:development Aug 6, 2020
vaibhavdaren added a commit that referenced this pull request Aug 6, 2020
* Implements markdown and priview functionality

* Parsing content within comment

* Comment notifications (#501)

* Initial

* Addition of comments section

* requested changes

* Changes for Jitsi UI (#518)

* css changes for jitsi box ui change

* edited jitsi.scss for jitsi ui and reverted changes of comment.scss

* changes made for making same fonts

* added modals in jitsi ui

* removed unnecessary code from jitsi.scss

* fixing dev branch issues (#525)

* implemented user activity and fix inconsistencies (#527)

* Settings integrate and deploy configuration (#530)

* integrated settings page and user activity modification

* configure to deploy

* Insights (#529)

* Adding reactGA

* Insights section

* removing /hompage path

* Requested changes

* initial changes

* Fetching data from the backend and integrating redux

* Fixing modal issues (#531)

* social links fix (#545)

* fix issues (#555)

* Fixing proposal functionality issues (#553)

Co-authored-by: Asel <peirisasel373@gmail.com>
Co-authored-by: Nisarg Shah <nisshah1499@gmail.com>
Co-authored-by: Rupesh Krishna Jha <rupeshiya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants