-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed issues #555
fixed issues #555
Conversation
@ayushnagar123 @jaskiratsingh2000 Plz review |
65adae0
to
b3a88e2
Compare
Done @ayushnagar123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done
As I have mentioned previously that actual buttons should be used for social handles. |
@jaskiratsingh2000 That's fixed in #558 |
* Implements markdown and priview functionality * Parsing content within comment * Comment notifications (#501) * Initial * Addition of comments section * requested changes * Changes for Jitsi UI (#518) * css changes for jitsi box ui change * edited jitsi.scss for jitsi ui and reverted changes of comment.scss * changes made for making same fonts * added modals in jitsi ui * removed unnecessary code from jitsi.scss * fixing dev branch issues (#525) * implemented user activity and fix inconsistencies (#527) * Settings integrate and deploy configuration (#530) * integrated settings page and user activity modification * configure to deploy * Insights (#529) * Adding reactGA * Insights section * removing /hompage path * Requested changes * initial changes * Fetching data from the backend and integrating redux * Fixing modal issues (#531) * social links fix (#545) * fix issues (#555) * Fixing proposal functionality issues (#553) Co-authored-by: Asel <peirisasel373@gmail.com> Co-authored-by: Nisarg Shah <nisshah1499@gmail.com> Co-authored-by: Rupesh Krishna Jha <rupeshiya@gmail.com>
PR contains fix for:
resolve #540
resolve #543
resolve #538
resolve #550
resolve #536
resolve #534
resolve #523
Fix
Screenshots:
![image](https://user-images.githubusercontent.com/31209617/89149004-092e2680-d579-11ea-8d7a-a9cb439e3dcd.png)
1. Login/Signup scroll fix
2. Invite link fix:
![bandicam-2020-08-03-11-00-13-530](https://user-images.githubusercontent.com/31209617/89149985-3aa7f180-d57b-11ea-8d8f-30e7cc2ffd8d.gif)
GIF:
3. All date format fix:
![image](https://user-images.githubusercontent.com/31209617/89149116-45618700-d579-11ea-97c8-463e6060c0f9.png)
4. Forgot password
![bandicam-2020-08-03-11-58-39-498](https://user-images.githubusercontent.com/31209617/89152626-236c0280-d581-11ea-9669-cd73b3299103.gif)