Settings integrate and deploy configuration #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rupeshiya
changed the title
devesh-verma
requested changes
Jul 25, 2020
There was a problem hiding this comment.
@Rupeshiya https://deploy-preview-530--codeuino-donut.netlify.app/dashboard can we fix these bugs to in this PR itself.
check the browser console.
@AuraOfDivinity I can see you have hardcoded the URL for socket.io to localhost.
Rupeshiya
force-pushed
the
settings_integrate
branch
3 times, most recently
from
7624595
to
00087f0
Compare
|
@devesh-verma Please check once again and also I have checked the backend you deployed is not having updated code.
For testing you can login with: Cheers!! 😄 |
Rupeshiya
force-pushed
the
settings_integrate
branch
from
00087f0
to
db4ca4d
Compare
|
@AuraOfDivinity Please fix the modal issue ASAP. |
Rupeshiya
force-pushed
the
settings_integrate
branch
from
db4ca4d
to
f773295
Compare
|
@Rupeshiya Modal issue fixed at #531. Please have a look. |
Rupeshiya
force-pushed
the
settings_integrate
branch
2 times, most recently
from
0954d32
to
3c9bafb
Compare
Rupeshiya
force-pushed
the
settings_integrate
branch
from
3c9bafb
to
a1efe74
Compare
vaibhavdaren
added a commit
that referenced
this pull request
Aug 6, 2020
* Implements markdown and priview functionality * Parsing content within comment * Comment notifications (#501) * Initial * Addition of comments section * requested changes * Changes for Jitsi UI (#518) * css changes for jitsi box ui change * edited jitsi.scss for jitsi ui and reverted changes of comment.scss * changes made for making same fonts * added modals in jitsi ui * removed unnecessary code from jitsi.scss * fixing dev branch issues (#525) * implemented user activity and fix inconsistencies (#527) * Settings integrate and deploy configuration (#530) * integrated settings page and user activity modification * configure to deploy * Insights (#529) * Adding reactGA * Insights section * removing /hompage path * Requested changes * initial changes * Fetching data from the backend and integrating redux * Fixing modal issues (#531) * social links fix (#545) * fix issues (#555) * Fixing proposal functionality issues (#553) Co-authored-by: Asel <peirisasel373@gmail.com> Co-authored-by: Nisarg Shah <nisshah1499@gmail.com> Co-authored-by: Rupesh Krishna Jha <rupeshiya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
@vaibhavdaren @devesh-verma Please review