Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing modal issues #531

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Conversation

AuraOfDivinity
Copy link
Collaborator

@AuraOfDivinity AuraOfDivinity commented Jul 26, 2020

This PR

  • Fixes the issue with the height of the modals.
  • Replaces the tabs implemented by @Rupeshiya at the add post Modal.
  • Includes styling for tabs within the _modal.scss for future modals containing tabs.

@Rupeshiya @vaibhavdaren @devesh-verma Please have a look.

image

@Rupeshiya
Copy link
Member

Rupeshiya commented Jul 26, 2020

@AuraOfDivinity Please add screenshot to other modals as well. For event modals, post modal, follower, admins. (These were affected)

@@ -2,16 +2,16 @@
border-radius: 20px;
.modal-content {
border-radius: 10px;

max-height: 70vh;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the other modals as well. I am sure this is going to create some issue with the othe modals.

@vaibhavdaren vaibhavdaren merged commit 3b8de03 into codeuino:development Jul 27, 2020
vaibhavdaren added a commit that referenced this pull request Aug 6, 2020
* Implements markdown and priview functionality

* Parsing content within comment

* Comment notifications (#501)

* Initial

* Addition of comments section

* requested changes

* Changes for Jitsi UI (#518)

* css changes for jitsi box ui change

* edited jitsi.scss for jitsi ui and reverted changes of comment.scss

* changes made for making same fonts

* added modals in jitsi ui

* removed unnecessary code from jitsi.scss

* fixing dev branch issues (#525)

* implemented user activity and fix inconsistencies (#527)

* Settings integrate and deploy configuration (#530)

* integrated settings page and user activity modification

* configure to deploy

* Insights (#529)

* Adding reactGA

* Insights section

* removing /hompage path

* Requested changes

* initial changes

* Fetching data from the backend and integrating redux

* Fixing modal issues (#531)

* social links fix (#545)

* fix issues (#555)

* Fixing proposal functionality issues (#553)

Co-authored-by: Asel <peirisasel373@gmail.com>
Co-authored-by: Nisarg Shah <nisshah1499@gmail.com>
Co-authored-by: Rupesh Krishna Jha <rupeshiya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants