Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Entry theme selection #764

Closed
wants to merge 38 commits into from
Closed

[WIP] Entry theme selection #764

wants to merge 38 commits into from

Commits on May 19, 2017

  1. Integrate themes with features

    @aviav
    aviav committed May 19, 2017
    Configuration menu
    Copy the full SHA
    1610f04 View commit details
    Browse the repository at this point in the history

  2. Use more specific config where needed

    @aviav
    aviav committed May 19, 2017
    Configuration menu
    Copy the full SHA
    c750128 View commit details
    Browse the repository at this point in the history

  3. Adjust specs to themes as features

    @aviav
    aviav committed May 19, 2017
    Configuration menu
    Copy the full SHA
    3ff4194 View commit details
    Browse the repository at this point in the history

  4. Test that themes registered in disabled features cannot be used

    @aviav
    aviav committed May 19, 2017
    Configuration menu
    Copy the full SHA
    490d835 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2017

  1. Placate Hound

    @aviav
    aviav committed May 22, 2017
    Configuration menu
    Copy the full SHA
    805bdeb View commit details
    Browse the repository at this point in the history

  2. Add theme name to revisions on database

    @aviav
    aviav committed May 22, 2017
    Configuration menu
    Copy the full SHA
    6b317c6 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2017

  1. On creating an entry, set theme_name on its revision 

    - also move setting home_button_enabled to theming
- rename copy_default_meta_tags to reflect this change and make it
  private
- test the public API method instead of the now private helper
    @aviav
    aviav committed May 28, 2017
    Configuration menu
    Copy the full SHA
    0191ddb View commit details
    Browse the repository at this point in the history

Commits on May 29, 2017

  1. Add preview_image_path theme attribute

    @aviav
    aviav committed May 29, 2017
    Configuration menu
    Copy the full SHA
    20e061e View commit details
    Browse the repository at this point in the history

  2. Add themes to editor seeds

    @aviav
    aviav committed May 29, 2017
    Configuration menu
    Copy the full SHA
    f6b0c4e View commit details
    Browse the repository at this point in the history

Commits on May 30, 2017

  1. Add theme_name to PublishedEntry

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    28fcd49 View commit details
    Browse the repository at this point in the history

  2. Add default images to theme generator

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    cb2f6d2 View commit details
    Browse the repository at this point in the history

  3. Make selectable themes a feature to keep API intact

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    9829d74 View commit details
    Browse the repository at this point in the history

  4. Make themes as features configurable per entry

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    49c183c View commit details
    Browse the repository at this point in the history

  5. Include themes according to entry config in their own seed section

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    a7454ed View commit details
    Browse the repository at this point in the history

  6. Add current theme name and button to appearance tab

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    0cbfb5b View commit details
    Browse the repository at this point in the history

  7. Add current theme name to entry seed and config

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    4a5c064 View commit details
    Browse the repository at this point in the history

  8. Add styling

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    75e73a7 View commit details
    Browse the repository at this point in the history

  9. Add theme picker dialog

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    cbf594b View commit details
    Browse the repository at this point in the history

  10. Add hover and select functionality

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    b125db7 View commit details
    Browse the repository at this point in the history

  11. Update stylesheet when theme is picked

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    9c2be51 View commit details
    Browse the repository at this point in the history

  12. Set up themes for editor

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    6ed1829 View commit details
    Browse the repository at this point in the history

  13. Fix typos

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    bb7943a View commit details
    Browse the repository at this point in the history

  14. Rework styling

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    2f0b93f View commit details
    Browse the repository at this point in the history

  15. Update chosen theme in ChangeThemeView on theme change

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    12a7420 View commit details
    Browse the repository at this point in the history

  16. Introduce editor model and collection for themes

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    7ad88be View commit details
    Browse the repository at this point in the history

  17. Use Backbone get instead of reaching into attributes

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    f43c7ba View commit details
    Browse the repository at this point in the history

  18. Refactor stylesheet utils

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    559e197 View commit details
    Browse the repository at this point in the history

  19. Display labelText current value in separate element

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    ad29bd3 View commit details
    Browse the repository at this point in the history

  20. Reuse ReferenceInputView and ModelThumbnailView

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    03d7478 View commit details
    Browse the repository at this point in the history

  21. Fix page title hysteresis 

    On choosing a page link, properly update title when it should be an
empty string. Without this, e.g. in ReferenceInputView, `title` will
not update in certain situations, because page#title() returns
`'undefined'` due to `''` falsiness in Javascript.

To reproduce:
```
this.configuration.get('title') === ''
this.configuration.get('additional_title') === undefined
```
    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    8724482 View commit details
    Browse the repository at this point in the history

  22. Introduce dedicated preview thumbnails for themes 

    To be stored at
`app/assets/images/pageflow/themes/$THEME_NAME/preview_thumbnail.png`.
    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    98fb650 View commit details
    Browse the repository at this point in the history

  23. Add editor specs

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    36ad364 View commit details
    Browse the repository at this point in the history

  24. Add inline documentation to ReferenceInputView#chooseValue

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    8684d9e View commit details
    Browse the repository at this point in the history

  25. Allow changing themes if selectable themes are enabled

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    9c87845 View commit details
    Browse the repository at this point in the history

  26. Add some inline documentation to ReferenceInputView 

    Just from the code we cannot tell that there is a recommended way to
deal with different attribute names.
    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    efb03b7 View commit details
    Browse the repository at this point in the history

  27. Use theming factory in updated specs

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    936ea61 View commit details
    Browse the repository at this point in the history

  28. Introduce dedicated preview thumbnails for themes 

    To be stored at
`app/assets/images/pageflow/themes/$THEME_NAME/preview_thumbnail.png`.
    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    d83ec1a View commit details
    Browse the repository at this point in the history

  29. Add default image assets to default theme

    @aviav
    aviav committed May 30, 2017
    Configuration menu
    Copy the full SHA
    7e45b84 View commit details
    Browse the repository at this point in the history