Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in jquery-ui/draggable #770

Closed
wants to merge 1 commit into from
Closed

Pull in jquery-ui/draggable #770

wants to merge 1 commit into from

Conversation

tilsammans
Copy link
Contributor

This is being used in admin/entries.js

@tilsammans
Copy link
Contributor Author

Stand by for an updated pull request; I believe it's enough when this is in admin.js.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.032% when pulling 2b12a6b on tilsammans:patch-1 into 44b9d85 on codevise:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.032% when pulling 2b12a6b on tilsammans:patch-1 into 44b9d85 on codevise:master.

@tilsammans
Copy link
Contributor Author

On second thought; this PR fixes the issue and it's at home along all the other jquery-ui imports.

I am leaving this as-is unless @tf tells me otherwise.

@tilsammans
Copy link
Contributor Author

Error message without this fix:

couldn't find file 'jquery.ui.draggable' with type 'application/javascript'
      Checked in these paths: 
        /Users/joost/Rails/scrollytelling/app/assets/fonts
        /Users/joost/Rails/scrollytelling/app/assets/images
        /Users/joost/Rails/scrollytelling/app/assets/javascripts
        /Users/joost/Rails/scrollytelling/app/assets/stylesheets
        /Users/joost/Rails/scrollytelling/vendor/assets/javascripts
        /Users/joost/Rails/scrollytelling/vendor/assets/stylesheets
        ... (lots more paths)

@tilsammans
Copy link
Contributor Author

I had a bit more time to investigate this issue, and it was actually caused by an outdated version of pageflow-before-after. Since I switched to master for that one, the correct requires are used for jquery-ui-rails 5.

@tilsammans tilsammans closed this May 24, 2017
@tilsammans tilsammans deleted the patch-1 branch May 24, 2017 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants