-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate - sum of an array #73
Comments
My opinion:
I'd say: retire 3. and 4. as useless. Retire 5 due to low quality. I hesitate between 1. and 2. because 1. is most feature-rich, but also flawed, and 2. is at least slightly interesting, but unfortunately lacks translations. |
There're already plenty of katas where you have to extend an existing class; sometimes it's explicitly mentioned as a requirement and sometimes it isn't which makes it ambiguous whether it's a part of the (incomplete) specifications or just the author's design choice. Since we're speaking about deduplication here, choose which of these points is true, and judge accordingly:
IMO, leave |
I also think keep option 1 and retire the rest. There are already other katas better suited to extending objects (summing only works when the contents are numbers, or maybe strings). Edit: Burn number 5 with fire |
Or just generate safe input, something like 1000 x |
Same opinion as Kacarott & Farekkusu ~~ For 1. , we can choose to remove floating point numbers from some languages or keep them based on which one is easier to handle Edit: send 5. back to the grave |
Keep 1, 2. Retire 3, 4. It is better to test integer arrays only in 1. |
I consider the best to retire 3 and 4 as they ask actually (despite requiring recursion and using of the reduce function - without enforcing it) the same thing. |
Keep 1 and 2. The task is very different and 2 is interesting per se. 3 and 4 are merely senseless duplicates of 1 since requirements aren't enforced. Make them mandatory would be make new katas from scratch, andhowver I'm not sure it presents a great interest. |
Actually, 2. should be retired since it is a subset duplicate of https://www.codewars.com/kata/52195c9bb576caf14200007f/discuss Also, https://www.codewars.com/kata/559f35bde66a7250f60000c9/discuss/javascript is actually kinda of a duplicate to all these too (I missed this one upon adding time, sorry) . It has:
Any opinions on this? Or should we discuss in another thread on retiring low quality katas? @hobovsky |
vote for keep # 1 edit for # 5: vote to also retire # 5 |
Since there are some votes to keep 2., I will remove it from this set of duplicates and eventually include it in another set related to extensions methods (like Adding useful functional functionality to JavaScript arrays). |
I added Sum with Arrows as it was discovered after this discussion was created. Please edit your responses to add your suggestion on 5. |
The intention of # 3 is to introduce beginners to reduce(), so I would not consider it to be a duplicate of any of the other kata listed here. |
@FesterBesterTester I know you're the author of the 3rd kata, but the thing is "duplicates" are not defined as having the same idea / concept anymore, instead, katas with direct questioning, requesting for identical solution are considered as dup despite yours having extra reinforcements ~~ Since your kata's solution can be retrieved from the first one and there's alr tons of kata solution out there that uses BTW: @monadius @CiprianAmza @FArekkusu @akar-0 , Any opinion on 5th kata? |
Keep 1 only. I think it's not a real problem that some languages use floats while other use integers. AFAIK only in NASM it is signigicatively more difficult to handle floats in a kata like this one. I know this opinion doesn't seem widely shared among the community, but I think it is not so important to invalidate solutions when it brings some benefice, for the kata and the general quality of Codewars. So I would favour to just use integers everywhere and make an explicit description. @ejini6969 : I don't like this kata, I just see no point in doing this, but I have no real argument here, this is just a subjective opinion. |
Sum The Array(removed as not a duplicate, see this post)Use reduce() to calculate the sum of the values in an array
reduce
, but it's not enforced too well.ADDED:
Points to discuss:
Conclusion
The text was updated successfully, but these errors were encountered: