Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some words to glossary #31

Merged
merged 9 commits into from
Jul 12, 2020
Merged

Add some words to glossary #31

merged 9 commits into from
Jul 12, 2020

Conversation

Blind4Basics
Copy link
Contributor

Starting point, to see how it behaves.

I didn't update the stump that was already there (dan/kyus/...)

note @kazk : what do you expect to write about TDD considering the TODO note that is there?

@Blind4Basics
Copy link
Contributor Author

#23

@Blind4Basics
Copy link
Contributor Author

...okay... I totally failed the formatting... x)
Surely the multiline description that are wrong. I'll see about that tomorrow (if anyone has the answer on hand, do not hesitate to tell me... x) )

@kazk
Copy link
Member

kazk commented Jul 10, 2020

note @kazk : what do you expect to write about TDD considering the TODO note that is there?

Nothing. That was just an example to show you guys that Markdown can be used :)

data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
@kazk
Copy link
Member

kazk commented Jul 10, 2020

It was failing because you had : in unquoted string which is a reserved character.
Quoting a string is optional in YAML, but you can run into issues like this.

data/glossary.yml Outdated Show resolved Hide resolved
@kazk kazk changed the title Update glossary.yml Add some words to glossary Jul 10, 2020
@Blind4Basics
Copy link
Contributor Author

x/

Damn it... The linter swallows it, but the other verifications are failing and I don't get why...

  • no colons
  • I tried removing the / in the term section of Approve (kata/translation)
  • I just corrected a typo and exchanged 2 terms that weren't in alphabetic order

... => ?? :(

@kazk
Copy link
Member

kazk commented Jul 12, 2020

Other checks failed because of some cache issues on Netlify Build. Probably related packages on this branch not matching the one on master because I updated some few days ago.

I rebuilt after clearing the cache and it’s fine now.

Don’t merge this yet. I’ll squash merge later because commits are messy.

data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
Copy link
Member

@kazk kazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these. There are some descriptions I don't really understand (odd translation?), but we can fix them later.

@kazk kazk merged commit 27176dc into master Jul 12, 2020
@kazk kazk deleted the Update-glossary branch July 12, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants