Polymedia leaderboard #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
.leaderboard-nameand in the.game-infocard.The leaderboard HTML is updated asynchronously to avoid blocking the rendering of the UI. So there are no additional delays in displaying the leaderboard addresses to the user. The addresses get updated when the profiles are ready from
0x12...3456toJohn Doe (0x12...3456).I noticed this codebase uses an older version of the Sui SDK,
@mysten/sui.js@0.33.0. Recent versions of the Sui SDK deprecated a number of interfaces and classes. This resulted in some dependency compatibility issues when installing the latest version of@polymedia/profile-sdk. To solve this, I released a custom version of the Polymedia Profile SDK,@polymedia/profile-sdk@1.4.0-mysten033, that uses the same Sui SDK version as this project. If you upgrade your@mysten/sui.jsdependency, it will be straightforward to also upgrade to the latest version of@polymedia/profile-sdk: mainly you'll have to pass a SuiClient instead of a JsonRpcProvider to the ProfileManager constructor.