Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Project README forum link now points to the actual forum page instead… #33

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Project README forum link now points to the actual forum page instead… #33

merged 1 commit into from
Jan 28, 2020

Conversation

jflopezfernandez
Copy link
Member

@jflopezfernandez jflopezfernandez commented Jan 28, 2020

Fix for Issue #32

Project README forum link now points to the actual forum page instead of resulting in a 404 error.

@luap42 luap42 self-requested a review January 28, 2020 18:21
@luap42 luap42 merged commit f808ed8 into codidact:develop Jan 28, 2020
@jflopezfernandez jflopezfernandez deleted the jflopezfernandez/32/correct-forum-url-in-readme branch January 28, 2020 18:25
@ranolfi
Copy link
Member

ranolfi commented Jan 29, 2020

Thank you for your contribution, review and merging, @jflopezfernandez and @luap42.

Not intending to be nit-picky, but as a heads-up, this commit subject line length is 99 characters. If I can offer a suggestion going forward, please keep in mind the 70-75 char limit from https://github.com/codidact/core/wiki/Committing-guidelines in the future :)

@jflopezfernandez
Copy link
Member Author

@ranolfi Yea, that's my bad, I was just being lazy and -m "<subject>" committing the requests, but I'll make sure to heed the committing guidelines from now on

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants