Questions

[misha130]

Pull Request summary

• Handles requests for a question list
• Displays a page for a question list
• Validation on said request
• Unit tests on said requests

Link to Project Card/Issue

#78

Pull Request Tasklist

• Pull request references an issue
• Branch follows contributing guidelines format
• Pull request targets the develop branch

[misha130]

Well this is what we have so far @luap42

[luap42]

Reviewing this now. I think the seed script is nice, but we'll need some "set up a community" script later, when we come closer to deploying it live.

[misha130]

Reviewing this now. I think the seed script is nice, but we'll need some "set up a community" script later, when we come closer to deploying it live.

Something more complete, yes. Also pull since I added category handling

[luap42]

Looks fine now. Running the tests and then this should be ready for merge.

[luap42]

Q&A posts sounds strange. Here should be the category name and/or the post type. So something like "Questions" or "Main Questions".

[misha130]

I fixed this by adding to the query result the category but ideally I should have an area/component/whatever that does this separately from the questions query like some community data.

Also added a short explanation below the category name.

    <div class="grid--cell is-flexible">
        <h1 class="has-margin-0">@Model.Result.Category.DisplayName Questions</h1>
        <h3>@Model.Result.Category.ShortExplanation</h3>
    </div>

[luap42]

Running the tests fails with this message:

Error Message:
System.Exception : Category not found:
Stack Trace
at Codidact.Core.Application.Questions.Queries.QuestionsQuery.QuestionsQuery.AddFiltersToQuery(QuestionsQueryRequest request, IQueryable`1 questionsQuery) in XXX\CodidactCore\src\Application\Questions\Queries\QuestionsQuery\QuestionsQuery.cs:line 69
at Codidact.Core.Application.Questions.Queries.QuestionsQuery.QuestionsQuery.Handle(QuestionsQueryRequest request) in XXX\CodidactCore\src\Application\Questions\Queries\QuestionsQuery\QuestionsQuery.cs:line 34
at Codidact.Core.Application.IntegrationTests.Questions.QuestionsQueryTests.QueryShouldReturnResultsByDefaults() in XXX\CodidactCore\tests\Application.UnitTests\Questions\QuestionsQueryTests.cs:line 30

[misha130]

Running the tests fails with this message:

Updated to handle categories

Outdated

[ArtOfCode-]

This is mostly a syntax/style review, rather than techniques. Couple of minor changes, but mostly good to go.

[ArtOfCode-]

You're missing some spacing in the ternary expression in the class attribute here (and likewise in the next two lines).

[misha130]

Could've been something like:

    @foreach (var sortType in (QuestionsQuerySortType[]) Enum.GetValues(typeof(QuestionsQuerySortType)))
    {
        <a asp-page="questions" asp-route-sort="@sortType" class="button is-muted is-outlined @(query.Sort == sortType ? "is-active" : "")">@sortType</a>
    }

But for now just formatted the condition

[ArtOfCode-]

DB seed should probably be split off into a separate file/task at some point. Not one for this PR, though.

[ArtOfCode-]

Have we got Babel preprocessing set up yet? If not, we should make that a priority. If we do, this file should be reviewed and updated to ES6 - notably, const and () => { }.

[misha130]

Not yet basically. Keeping it ES3 so far

[ArtOfCode-]

Works for now. Just bear in mind that the longer it takes to get it set up, the more JS there'll be to rewrite when it's ready :)

[luap42]

@misha130 please merge develop into this PR and resolve the conflicts, theb we can merge this PR.

[misha130]

@misha130 please merge develop into this PR and resolve the conflicts, theb we can merge this PR.

Ok done