Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Fix empty file bugs #415

Merged
merged 4 commits into from
Apr 4, 2018
Merged

Fix empty file bugs #415

merged 4 commits into from
Apr 4, 2018

Conversation

catsuryuu
Copy link
Contributor

@catsuryuu catsuryuu commented Mar 14, 2018

This change is Reviewable

@catsuryuu catsuryuu requested a review from mkow March 14, 2018 04:12
@mkow
Copy link
Contributor

mkow commented Mar 14, 2018

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


include/ui/hexedit.h, line 48 at r1 (raw file):

   * visible */
  void setSelection(qint64 start, qint64 size, bool set_visible = false,
                    bool reset_pos_in_byte = true);

Maybe a better idea would be to allow setting this position instead of resetting? i.e. qint64 pos_in_byte = 0


Comments from Reviewable

@catsuryuu
Copy link
Contributor Author

Review status: 2 of 4 files reviewed at latest revision, 1 unresolved discussion.


include/ui/hexedit.h, line 48 at r1 (raw file):

Previously, mkow (Michał Kowalczyk) wrote…

Maybe a better idea would be to allow setting this position instead of resetting? i.e. qint64 pos_in_byte = 0

Done.


Comments from Reviewable

@mkow
Copy link
Contributor

mkow commented Mar 28, 2018

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@catsuryuu catsuryuu force-pushed the wip/catsuryuu/empty-file-patch branch from c693452 to 1ea8b0a Compare March 29, 2018 21:11
@mkow mkow merged commit f2a8040 into master Apr 4, 2018
@mkow mkow deleted the wip/catsuryuu/empty-file-patch branch April 4, 2018 10:25
@mkow mkow mentioned this pull request Apr 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants