This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
asrv: Rename files #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altran01
approved these changes
Mar 20, 2017
mkow
reviewed
Mar 20, 2017
python/srv
Outdated
| else: | ||
| print('Starting TCP server.') | ||
| loop.run_until_complete(veles.asrv.proto.tcp_server(srv, host, int(port))) | ||
| loop.run_until_complete(tcp_server(conn, host, int(port))) | ||
| print('Ready.') | ||
| # loop.add_signal_handler(signal.SIGINT, loop.stop) |
There was a problem hiding this comment.
Not related to this PR, but why is this commented out? Please write a comment with reason or delete.
There was a problem hiding this comment.
I don't see any near future where this can be restored - the problem is that add_signal_handler isn't available on Windows so we can't use it :(
So lets remove it.
There was a problem hiding this comment.
try: ... except AttributeError: pass?
python/veles/server/proto.py
Outdated
| @asyncio.coroutine | ||
| def unix_server(srv, path): | ||
| return (yield from srv.loop.create_unix_server(lambda: Proto(srv), path)) | ||
| async def unix_server(conn, path): |
There was a problem hiding this comment.
nit: rename to create_unix_server
python/veles/server/proto.py
Outdated
| @asyncio.coroutine | ||
| def tcp_server(srv, ip, port): | ||
| return (yield from srv.loop.create_server(lambda: Proto(srv), ip, port)) | ||
| async def tcp_server(conn, ip, port): |
There was a problem hiding this comment.
nit: rename to create_tcp_server
mwkmwkmwk
force-pushed
the
wip/mwk/asrv-rename
branch
from
1176ccf
to
1e1154a
Compare
mwkmwkmwk
changed the base branch from
wip/mwk/use-pos-filter
to
wip/mwk/root-id
mwkmwkmwk
force-pushed
the
wip/mwk/asrv-rename
branch
from
1e1154a
to
9491461
Compare
altran01
added a commit
that referenced
this pull request
Mar 29, 2017
This is fix for regression introduced in PR #87 where wrong exception type was assumed to be thrown by add_signal_handler on Windows
altran01
added a commit
that referenced
this pull request
Mar 29, 2017
This is fix for regression introduced in PR #87 where wrong exception type was assumed to be thrown by add_signal_handler on Windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.