Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materialize The App #101

Merged
merged 11 commits into from
Jun 6, 2018
Merged

Materialize The App #101

merged 11 commits into from
Jun 6, 2018

Conversation

aggarwalpulkit596
Copy link
Contributor

Fixes #97

Changes:
Added Room Activity and Prefence Activity
Removed Unnecessary Fragments
Removed BottomNavigationbar in DashBoard Activity
Screenshots for the change:
screenshot-1527955081162
Uploading screenshot-1527955097784.jpg…
Uploading screenshot-1527955107438.jpg…

@aggarwalpulkit596
Copy link
Contributor Author

screenshot-1527955097784
screenshot-1527955107438

@aggarwalpulkit596
Copy link
Contributor Author

@championswimmer kindly review this pr as well

@the-dagger
Copy link

@aggarwalpulkit596 Can we have different fontSize for message, the sender name, date, etc.
Also please make the sender name as bold and make the links clickable.

@aggarwalpulkit596
Copy link
Contributor Author

Okay sure will do that right away

@aggarwalpulkit596
Copy link
Contributor Author

@the-dagger should i add images too in the messages?

@aggarwalpulkit596
Copy link
Contributor Author

screenshot-1528150567170
i've fixed the layout added links,images of sender and also corrected the logic of fetching messages from message table which was a simple additional check in the query that is
messages = realm.where(MessagesTable.class)
.greaterThan("id", 0)
.equalTo("roomId", roomId)
.findAllSorted("id", Sort.DESCENDING);

"roomId" = roomId passed via intent is added in this query

@aggarwalpulkit596
Copy link
Contributor Author

@the-dagger bhaiya also check it is showing conflict when i try to add userimage in the adapter

@the-dagger
Copy link

@aggarwalpulkit596 No need to use cards for the list item here in the chat rooms.
It makes the content harder to read.

Cards generally should be avoided in a RecyclerView if the content is distinct enough or doesn't contain rich visual content.

@aggarwalpulkit596
Copy link
Contributor Author

Okay @the-dagger will do that asap and kindly review code for database restructuring.

aggarwalpulkit596 added 2 commits June 5, 2018 19:10
@aggarwalpulkit596
Copy link
Contributor Author

screenshot-1528205998333
Fixed Layout

@the-dagger the-dagger merged commit df384ca into coding-blocks:development Jun 6, 2018
manav-mj pushed a commit to manav-mj/Chatter that referenced this pull request Jun 8, 2018
* changed to copytorealm to copyToRealmOrUpdate

* Populating the messages in room

* Materlized the App

* Fixed Layout for messages and logic for fetching messages from database

* Resolved Merge Conflict

* Resolved Merge Conflict

* Resolved Merge Conflict
Trying one last time.

* Add linkify

* Removed Card View From Message layout

Signed-off-by: aggarwalpulkit596 <app.mathonogo@gmail.com>
manav-mj pushed a commit to manav-mj/Chatter that referenced this pull request Jun 8, 2018
* changed to copytorealm to copyToRealmOrUpdate

* Populating the messages in room

* Materlized the App

* Fixed Layout for messages and logic for fetching messages from database

* Resolved Merge Conflict

* Resolved Merge Conflict

* Resolved Merge Conflict
Trying one last time.

* Add linkify

* Removed Card View From Message layout

Signed-off-by: aggarwalpulkit596 <app.mathonogo@gmail.com>
manav-mj pushed a commit to manav-mj/Chatter that referenced this pull request Jun 8, 2018
* changed to copytorealm to copyToRealmOrUpdate

* Populating the messages in room

* Materlized the App

* Fixed Layout for messages and logic for fetching messages from database

* Resolved Merge Conflict

* Resolved Merge Conflict

* Resolved Merge Conflict
Trying one last time.

* Add linkify

* Removed Card View From Message layout

Signed-off-by: aggarwalpulkit596 <app.mathonogo@gmail.com>
manav-mj pushed a commit to manav-mj/Chatter that referenced this pull request Jun 8, 2018
* changed to copytorealm to copyToRealmOrUpdate

* Populating the messages in room

* Materlized the App

* Fixed Layout for messages and logic for fetching messages from database

* Resolved Merge Conflict

* Resolved Merge Conflict

* Resolved Merge Conflict
Trying one last time.

* Add linkify

* Removed Card View From Message layout

Signed-off-by: aggarwalpulkit596 <app.mathonogo@gmail.com>
This was referenced Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants