Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the null pointer exception on recyclerview layout at rooms fragment #44

Closed
wants to merge 2 commits into from
Closed

Conversation

RishabhRawatAndroid
Copy link
Contributor

Fix the issue #43

@manav-mj
Copy link
Contributor

You have changed a lot of things not related to the issue.

  1. Changes in AuthenticationActivity.java
  2. Changes in gradle
  3. Changes in DashboardFragment.java
  4. Changes in SettingsFragment.java

I think a separate issue should be created for every bug

@RishabhRawatAndroid
Copy link
Contributor Author

RishabhRawatAndroid commented May 15, 2018

@manav-mj Yes, brother but this is stable code for all fragments. Means if we are using the Fragment (Non-Activity) and if we want to bind the view on Fragment then we should use the ButterKnife.bind(this, view); that's why I put this in all fragments class for no more future error.

@manav-mj
Copy link
Contributor

Yes your code is stable and is required for further bug fixes to be implemented.
I am just suggesting to open different PR for every change (or) change the title of the issue you are addressing mentioning all the changes you intend to make for better and clearer documentation

@championswimmer
Copy link
Contributor

way too many things changed in single PR. please do not do like this.
target one pr at a time. make changes only related to that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants