-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
javascript node.js scripts #687
Conversation
As long as we can run the games in the browser for the JS versions, it's all good to me! |
2ba982f
to
a3c36ef
Compare
0d299a5
to
e97820a
Compare
324225a
to
50fedb2
Compare
@nanochess @stevebosman What do you think about this (big) change! I would be happy to hear your input! |
LGTM! Let's merge it and then discuss! |
Thanks for merging! Looks like the new node.js-terminal-emulator works: |
javascript node.js scripts
These games are meant as simple CLI scripts (see #117 (comment)).
I therefor think javascript should target mainly node.js instead of the browser (in opposite of whats currents implemented).
print
,input
andtab
. (see Intellij complains about dependencies in ConsoleTest.kt. #548 (comment)).*.mjs
extension.Here is an example of the emulator in action: https://mojoaxel.github.io/basic-computer-games/00_Common/javascript/WebTerminal/terminal.html#74_Rock_Scissors_Paper/javascript/rockscissors.mjs
This way we have the best of both worlds:
The following games already have been refactored to be valid node-script:
Please let me know what you think!!