Escape filenames which looks like regexp #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingjoe
requested changes
Oct 19, 2019
There was a problem hiding this comment.
@JanBednarik thanks for contributing. Interesting bug you found, good catch.
I believe the bugfix you proposed is perfectly fine, but please read my comment below. I'd like to split your improvement into a separate commit.
Thanks Joe 👍
codingjoe
approved these changes
Oct 24, 2019
|
Released in 1.1.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we have issue with files containing square braces in name.
globis reading them as regular expressions and crashes when expression is invalid. Filename likerelint "foo[a-b].yml"is fine andrelint "foo[b-a].yml"is crashing. To fix this filenames has to be escaped: https://docs.python.org/3/library/glob.html#glob.escapeWhen implementing fix, I had to improve tests a bit. First change is proper patching of
sys.argvandsys.stdinso tests does not have side effects on other tests.And second change is rewrite of
test_main_execution_with_diffto be reliable and doesn't break on changes intest_relint.py.