Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

feat: add static index page #50

Merged
merged 7 commits into from
Jun 14, 2018
Merged

feat: add static index page #50

merged 7 commits into from
Jun 14, 2018

Conversation

njlie
Copy link
Contributor

@njlie njlie commented Jun 13, 2018

No description provided.

Copy link
Contributor

@adrianhopebailie adrianhopebailie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested changes to text but not blocking.
This is great.

index.html Outdated
@@ -0,0 +1,37 @@
<html>
<h2>Welcome to Codius!</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this message should be addressed more to users of the host that the operator?
Example:

<h2>Codius Host</h2>
<p>This is server is a Codius Host running <a href="https://github.com/codius/codiusd">codiusd</a>. You can deploy contracts to this host using the <a href="https://github.com/codius/codius">Codius Client Command Line Interface (CLI)</a>.</p>
<p>For more information on codius visit <a href="https://codius.org">codius.org</a></p>

index.html Outdated
<td id="fullMem"></td>
</tr>
</table>
<p>You can view additional information about your Codius host at these links:</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above: s/about your/about this/

@traviscrist traviscrist self-requested a review June 14, 2018 16:32
Copy link
Contributor

@traviscrist traviscrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I agree with the suggestions by Adrian to make it more directed to anyone visiting the servers page rather than the host.

@njlie njlie merged commit 7e3603d into master Jun 14, 2018
@njlie njlie deleted the nl-static-index branch June 14, 2018 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants