Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/apple m1 support #297

Merged
merged 10 commits into from
Jan 14, 2021
Merged

Feature/apple m1 support #297

merged 10 commits into from
Jan 14, 2021

Conversation

amircodota
Copy link
Contributor

No description provided.

Copy link
Contributor

@dimacodota dimacodota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amircodota amircodota merged commit 55b9ba2 into master Jan 14, 2021
@amircodota amircodota deleted the feature/apple-m1-support branch January 14, 2021 14:06
ofekby pushed a commit that referenced this pull request Aug 1, 2023
* fix dl_binaries script

* add isAppleM1 function

* add support for apple m1

* fix

* use uname as another form of detecting m1

* add aarch64 binary

* move uname into if to avoid potential issues on windows

* ignore .idea when packaging vscode

* support only vscode arm64 native builds (no rosetta)

Former-commit-id: 226f60b0fe075d6e73a9088ae66f9c2693e5195b [formerly 83d4523736ef3621d0e73880751efe0aee1faae9] [formerly 0909d23e0ae1071a6bbbd9bdf062f2cf944b19e4 [formerly 55b9ba2]]
Former-commit-id: e2929675717ccbf126a71c9844d842a20332fe1f [formerly e3284d4ccf715280a66e4b0212668eaac8796dac]
Former-commit-id: 58c619e7e194c27a2b48c17df015cf5cd5f49fd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants