-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/apple m1 support #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimacodota
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…/apple-m1-support
This was referenced Jan 17, 2021
ofekby
pushed a commit
that referenced
this pull request
Aug 1, 2023
* fix dl_binaries script * add isAppleM1 function * add support for apple m1 * fix * use uname as another form of detecting m1 * add aarch64 binary * move uname into if to avoid potential issues on windows * ignore .idea when packaging vscode * support only vscode arm64 native builds (no rosetta) Former-commit-id: 226f60b0fe075d6e73a9088ae66f9c2693e5195b [formerly 83d4523736ef3621d0e73880751efe0aee1faae9] [formerly 0909d23e0ae1071a6bbbd9bdf062f2cf944b19e4 [formerly 55b9ba2]] Former-commit-id: e2929675717ccbf126a71c9844d842a20332fe1f [formerly e3284d4ccf715280a66e4b0212668eaac8796dac] Former-commit-id: 58c619e7e194c27a2b48c17df015cf5cd5f49fd4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.