Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Swipe-button #58

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Create a Swipe-button #58

merged 2 commits into from
Jun 23, 2024

Conversation

GrgSumin
Copy link
Contributor

Recording.2024-06-20.131848.mp4

@GrgSumin GrgSumin added the ready-for-review This pr is ready for review label Jun 20, 2024
@GrgSumin GrgSumin requested a review from hari June 20, 2024 07:34
Copy link

vercel bot commented Jun 20, 2024

@GrgSumin is attempting to deploy a commit to the Codse Team on Vercel.

To accomplish this, @GrgSumin needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

Copy link
Contributor

@hari hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrgSumin Here are a few things:

  1. You don't need to pass color and background as props. Just use the className and Tailwind colors.

  2. You shouldn't place both items absolutely; check my logic in the SwapText component.

  3. Looks like you are providing the fixed width for the button. Did you try using different texts to see if it fits?

@GrgSumin GrgSumin requested a review from hari June 20, 2024 10:52
@@ -0,0 +1,25 @@
import { Meta, StoryObj } from "@storybook/react";
import SwipeButton from "./swipe-button";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrgSumin This should be absolute import.

@hari hari merged commit a334377 into main Jun 23, 2024
1 check failed
@hari hari deleted the animata/Swipe-button branch June 23, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review This pr is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants