Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor should have light/dark mode #436

Closed
Tracked by #63
NiallJoeMaher opened this issue Sep 28, 2023 · 7 comments
Closed
Tracked by #63

Editor should have light/dark mode #436

NiallJoeMaher opened this issue Sep 28, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request hacktoberfest

Comments

@NiallJoeMaher
Copy link
Contributor

Context

So we can give a better user experience, we are working on a light/dark mode.

Expected Behavior

We use Tailwind, so we should enable this by having a default light mode and dark mode with the dark: prefix.
You can see how this is done here: https://tailwindcss.com/docs/dark-mode

Current Behavior

By default, we only use a dark theme.
You can see the editor here: https://www.codu.co/create

Additional info

The background for light mode should be: bg-neutral-100
The text should be: text-neutral-900
The cards should have a background of: bg-white
borders for light mode should be: neutral-100

If there is more questions let me know as I'm sure I've missed something!

@pateldivyesh1323
Copy link
Contributor

@NiallJoeMaher I would like to work on this.

@NiallJoeMaher
Copy link
Contributor Author

@pateldivyesh1323 I've assigned another one to you already so once that PR is open you can check back here and I can assign it if nobody else has started. 😁

@pateldivyesh1323
Copy link
Contributor

@NiallJoeMaher ok

@MuzhdaN
Copy link

MuzhdaN commented Oct 1, 2023

Hi :)
If this is not taken, can I take this one?

@NiallJoeMaher
Copy link
Contributor Author

All yours @MuzhdaN

@Sidopolis
Copy link

HI Sir
Can i get this one ?

@MuzhdaN
Copy link

MuzhdaN commented Oct 10, 2023

Hi,

On the editor page, I've noticed that some texts are using a grayish color (text-neutral-400). However, in the above requirements you didn't specify a color for this, so I've applied text-neutral-500 to "how to use the editor part" section for test. I wanted to check with you to see if this is acceptable.

Additionally, the buttons currently have a white background in light mode. Do you want this to remain as is, or should I make any adjustments?

Thank you,

here is the screenshot for the editor page:

Screenshot 2023-10-10 151052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants