Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karma webpack color option #332

Closed
spicalous opened this issue Jun 15, 2018 · 1 comment
Closed

Karma webpack color option #332

spicalous opened this issue Jun 15, 2018 · 1 comment

Comments

@spicalous
Copy link
Contributor

spicalous commented Jun 15, 2018

I'm submitting a feature request

It would improve consistency of configs if webpack's color config inherits Karma's color config

  • What is the motivation / use case for changing the behavior?

Would provide more consistency, similar to the same way that webpack currently uses Karma's singleRun config to determine the watch config:
https://github.com/webpack-contrib/karma-webpack/blob/master/src/karma-webpack.js#L42

Proposed behaviour

As a suggestion, the value could be determined as follows: Taking the next item in the list if the previous one is not defined:

  • webpack's color config value
  • karma's color config value
  • webpack's default color value (same as it is now)

Next step

I could contribute this and open a PR in the near future if the majority of the maintainers agree?

Thanks in advance!

Docs for reference

Webpack stats color docs: https://webpack.js.org/configuration/stats/?_sm_au_=iVVJFnC5DW5NQLFF#stats
Karma docs for color http://karma-runner.github.io/2.0/config/configuration-file.html

@michael-ciniawsky
Copy link
Contributor

Feel free to send a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants