Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pi4 vulkan support #1359

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Improve pi4 vulkan support #1359

merged 1 commit into from
Mar 28, 2021

Conversation

dpjudas
Copy link
Contributor

@dpjudas dpjudas commented Mar 28, 2021

Removed depthClamp requirement (note: portals will not render correctly on such devices).
Added format fallback support for VK_FORMAT_A2R10G10B10_UNORM_PACK32 since the pi4 doesn't support it.

…ly on such devices)

Added format fallback support for VK_FORMAT_A2R10G10B10_UNORM_PACK32 since the pi4 doesn't support it
Copy link
Collaborator

@alexey-lysiuk alexey-lysiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried simple portal test maps with depth clamp disabled, and they seem to work fine.
The only thing I noticed is visual glitch when moving through interactive portal.
It's an acceptable shortcoming I think.

@dpjudas
Copy link
Contributor Author

dpjudas commented Mar 28, 2021

It is. The shortcoming is actually exactly the same as was reported for softpoly recently. It too had no support for depth clamp. :)

@coelckers coelckers merged commit 4e503a1 into ZDoom:master Mar 28, 2021
@coelckers
Copy link
Member

Is lack of depth clamp a Pi4 issue or something more general with ARM? It's a bit strange for this recent hardware not having support for something being taken for granted for 10+ years.

@madame-rachelle
Copy link
Collaborator

This really should not have anything to do with ARM. The VideoCore processor (which is the Pi4's GPU) is embedded in the CPU like an integrated Intel GPU chip, but that's the extent of it. ARM processors, if in a system that supports them, can use full fledged NVidia/ATI GPU's that would not be affected by such a bug.

@madame-rachelle
Copy link
Collaborator

Also I think I should point out that this may also simply be a driver issue, as well.

@Cacodemon345
Copy link
Contributor

Has the lack of depth clamp been reported to the Mesa3D developers?

@madame-rachelle
Copy link
Collaborator

No. If anyone wants to do that be my guest. This issue simply is not important enough to me for me to bother.

@dpjudas
Copy link
Contributor Author

dpjudas commented Mar 28, 2021

The depth clamp thing isn't an ARM issue as the M1 runs it just fine without. It is either the pi4 driver not implementing depth clamp, or the GPU implementation not supporting it.

Note that this is technically not a bug. A vulkan compliant driver is allowed to not support depth clamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants