Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of "articles with the same reply" is missing #109

Closed
MrOrz opened this issue May 7, 2018 · 2 comments
Closed

List of "articles with the same reply" is missing #109

MrOrz opened this issue May 7, 2018 · 2 comments
Labels
good first issue help wanted

Comments

@MrOrz
Copy link
Member

MrOrz commented May 7, 2018 •
edited
Loading

This reply is used in multiple articles, but currently they are not listed anywhere.

https://cofacts.g0v.tw/reply/1R64K2MBSH_MLFhIol5t

https://cofacts.g0v.tw/reply/ux4g2GMBSH_MLFhI0WQ6

It should be in the same form as "related article" in the article page.
@MrOrz
Copy link
Member Author

MrOrz commented Mar 6, 2019 •
edited
Loading

Seems that renderUsedArticles in pages/reply.js always returns null. Need someone to investigate the cause.

But take https://cofacts.g0v.tw/reply/1R64K2MBSH_MLFhIol5t for example, the data is surely loaded. It's not displayed somehow.

2019-03-06 10 01 19

@jihchi jihchi mentioned this issue Mar 22, 2019
Merged
@MrOrz
Copy link
Member Author

MrOrz commented Mar 24, 2019

@jihchi 's fix now online. It is awesome! Thanks a million.

@MrOrz MrOrz closed this as completed Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrOrz