Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Default image #180

Merged
merged 13 commits into from
Mar 19, 2024
Merged

Default image #180

merged 13 commits into from
Mar 19, 2024

Conversation

TheDanMiller
Copy link
Collaborator

@TheDanMiller TheDanMiller commented Mar 19, 2024

Default image fallback

Summary

Incase the generation fails to create an image for an institution need a fallback image component
Related to #80

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How To Test

  1. Scroll to an institution with no image
  2. See the default
  3. Click into the instution
  4. See the default

Checklist:

  • My code follows the style guidelines of this project and has no linting errors
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, including any applicable ADRs
  • My changes generate no new warnings
  • I have added tests that fail without these changes
  • New and existing tests (unit, integration, accessibility) pass locally
  • Documentation updated
  • If there are security concerns they are addressed or ticketed after being discussed

@TheDanMiller TheDanMiller added bug Something isn't working enhancement New feature or request frontend For work that is primarily in the front end of the application labels Mar 19, 2024
@TheDanMiller TheDanMiller self-assigned this Mar 19, 2024
Copy link

codeclimate bot commented Mar 19, 2024

Code Climate has analyzed commit 89c256c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 87.6%.

View more on Code Climate.

@TheDanMiller TheDanMiller merged commit 4e8b21a into main Mar 19, 2024
29 checks passed
@TheDanMiller TheDanMiller deleted the bug/default-image branch March 19, 2024 23:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request frontend For work that is primarily in the front end of the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants