Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gym MultiDiscrete MultiBinary #130

Merged
merged 7 commits into from
Mar 1, 2023
Merged

Support Gym MultiDiscrete MultiBinary #130

merged 7 commits into from
Mar 1, 2023

Conversation

wduguay-air
Copy link
Contributor

Changes

  • Added support for gym spaces of type MultiDiscrete and MultiBinary
  • Test serialization case with all possibilities.
  • Upgrade hydra version

@wduguay-air wduguay-air self-assigned this Feb 26, 2023
@wduguay-air wduguay-air mentioned this pull request Feb 26, 2023
Closed
@cloderic
Copy link
Member

The python side looks good, can you do the js side at the same time in https://github.com/cogment/cogment-verse/blob/main/cogment_verse/web/web_app/src/utils/spaceSerialization.js ?

@cloderic
Copy link
Member

cloderic commented Mar 1, 2023

looks good to me 👍

@wduguay-air wduguay-air merged commit f338c29 into main Mar 1, 2023
@wduguay-air wduguay-air deleted the 129-support-gym-multidiscrete-multibinary branch March 1, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloderic cloderic cloderic approved these changes

Assignees

@wduguay-air wduguay-air

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wduguay-air @cloderic