-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Model Registry V2 #144
Conversation
Since the last review/conversation, I removed the |
Maybe you can have a look at some of the new functionality coming, to see if it would make sense to wait for the next version (excluding enterprise stuff): |
Anyways I was planning to wait a bit to wait for Ha to merge some agent implementations PRs that have been open for a long time. But for now, the current functionalities seem enough for the general cogment-verse use case. I will probably make a new PR in the near future to include them! |
All implementations PRs I was waiting for are merged. This is ready. |
I would suggest you go through and change The code also does not follow our coding guidelines, but it might be too much for this PR. |
I just made a pass to rename to |
closes #120
Overview
This pull request migrates the current Model Registry implementation to the Model Registry V2 implementation introduced by the SDK in release v2.5.0.
Testing
The functional tests will be added to the PR after merging the Functional Test PR #143.
Other changes