Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution cancellation dead code clean up #1753

Merged
merged 1 commit into from
May 6, 2024

Conversation

VerstraeteBert
Copy link
Contributor

Description

Dead code cleanups

@VerstraeteBert VerstraeteBert requested review from a team as code owners May 6, 2024 13:12
@VerstraeteBert VerstraeteBert requested review from erlendvollset and removed request for a team May 6, 2024 13:12
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (0632f98) to head (a7d819c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1753      +/-   ##
==========================================
+ Coverage   92.83%   92.88%   +0.05%     
==========================================
  Files         121      121              
  Lines       17495    17478      -17     
==========================================
- Hits        16241    16234       -7     
+ Misses       1254     1244      -10     
Files Coverage Δ
cognite/client/_api/workflows.py 92.18% <ø> (ø)
cognite/client/data_classes/__init__.py 100.00% <ø> (ø)
cognite/client/data_classes/workflows.py 95.09% <ø> (+1.92%) ⬆️

... and 1 file with indirect coverage changes

@VerstraeteBert VerstraeteBert merged commit 3da9fe2 into master May 6, 2024
8 checks passed
@VerstraeteBert VerstraeteBert deleted the execution-cancellation-cleanup branch May 6, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants