Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Allocate textures holding color and visibility to be big enough to hold the correct number of tree indices." #354

Closed
wants to merge 5 commits into from
Closed

Revert "Allocate textures holding color and visibility to be big enough to hold the correct number of tree indices." #354

wants to merge 5 commits into from

Conversation

dragly
Copy link
Contributor

@dragly dragly commented Mar 26, 2020

The shaders are still using fixed values. The lookups are therefore wrong and it is no longer possible to change the color or visiblity of nodes.

@dragly
Revert "Allocate textures holding color and visibility to be big enou…
fbed64a 
…gh to hold the correct number of tree indices. (#313)"

This reverts commit 4ff309b.
@dragly dragly added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch auto-merge labels Mar 26, 2020
@dragly dragly requested review from larsmoa and j-bjorne March 26, 2020 14:56
@dragly dragly self-assigned this Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3746a3b). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #354   +/-   ##
=========================================
  Coverage          ?   64.48%           
=========================================
  Files             ?       74           
  Lines             ?     2112           
  Branches          ?      182           
=========================================
  Hits              ?     1362           
  Misses            ?      748           
  Partials          ?        2
Impacted Files Coverage Δ
viewer/src/views/threejs/cad/MaterialManager.ts 83.33% <100%> (ø)
viewer/src/views/threejs/cad/materials.ts 100% <100%> (ø)
viewer/src/views/threejs/cad/CadNode.ts 71% <100%> (ø)

@larsmoa larsmoa mentioned this pull request Mar 26, 2020
Merged
larsmoa
larsmoa requested changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@larsmoa larsmoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, sorry. I've fixed the issue in #359 - I suggest we close this one if there's nothing I'm missing.

@dragly
Copy link
Contributor Author

dragly commented Mar 27, 2020

No worries ;) And great! I will test it.

@dragly
Copy link
Contributor Author

dragly commented Mar 27, 2020

#359 works. Closing.

@dragly dragly closed this Mar 27, 2020
@dragly dragly deleted the revert-313-larsmoa/allocate-correct-texture-size branch March 27, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsmoa larsmoa larsmoa requested changes

@j-bjorne j-bjorne Awaiting requested review from j-bjorne

Assignees

@dragly dragly

Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragly @larsmoa