Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mode filtering on last matches table #77

Closed
petrvecera opened this issue Sep 21, 2021 · 8 comments
Closed

Fix mode filtering on last matches table #77

petrvecera opened this issue Sep 21, 2021 · 8 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest

Comments

@petrvecera
Copy link
Member

https://coh2stats.com/players/76561198034318060?view=matches

Filtering in the table doesn't work for the mode. Other works.
image

Most likely issue with == vs === needs to be tested
https://github.com/petrvecera/coh2ladders/blob/master/packages/web/src/pages/matches/last-matches-table.tsx#L357

@petrvecera petrvecera added bug Something isn't working good first issue Good for newcomers Hacktoberfest labels Sep 21, 2021
@thenicekat
Copy link
Contributor

I would like to try working on this, can you assign it to me?

@thenicekat
Copy link
Contributor

When I tried npm install in web folder and then run npm start, I get these errors:
image
Can you tell if you have any idea to solve them?

@thenicekat
Copy link
Contributor

thenicekat commented Oct 2, 2021

okay so to solve them

change import en from "javascript-time-ago/locale/en"; to import en from "javascript-time-ago/locale/en.json";

and also change catch statement in player-card.tsx

catch (e) {
        let errorMessage = "Failed to do something exceptional";
        if (e instanceof Error) {
          errorMessage = e.message;
        }
        console.error(e);
        setError(errorMessage);
}

might help others working on it

@thenicekat
Copy link
Contributor

Sent the PR, Can you check it?

@petrvecera
Copy link
Member Author

@Divyateja04 our project is not actually managed by npm. We are using yarn. To properly install all the packages. You need to do yarn install from the root folder of the project.

@thenicekat
Copy link
Contributor

yeah sent an updated PR, can you check? and about those messages, I figured it out later, so deleted them...sorry

petrvecera added a commit that referenced this issue Oct 2, 2021
Fixed mode filtering on last matches table #77
@thenicekat
Copy link
Contributor

hey can you close this too?

@petrvecera
Copy link
Member Author

Thanks for the contribution 👍 :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants