Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

OT-757: Regression: Flagged Messages not filtered per Chat #484

Merged
merged 2 commits into from
Mar 26, 2020
Merged

OT-757: Regression: Flagged Messages not filtered per Chat #484

merged 2 commits into from
Mar 26, 2020

Conversation

phranck
Copy link
Contributor

@phranck phranck commented Mar 25, 2020 •
edited
Loading

Link to the given issue
Fixes #483, Closes #483

Fixes

  • adds missing chatId parameter when calling Flagged widget
  • comments some code out (needs to be discussed) for flagged messages per contact

@phranck phranck requested review from Boehrsi and florianhaar and removed request for Boehrsi March 25, 2020 15:57
florianhaar
florianhaar approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@florianhaar florianhaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@florianhaar florianhaar self-requested a review March 26, 2020 06:52
florianhaar
florianhaar suggested changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@florianhaar florianhaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one question :)

@florianhaar florianhaar merged commit 4ec43f4 into develop Mar 26, 2020
@florianhaar florianhaar deleted the OT-757_RegressionFlaggedMessages branch March 26, 2020 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@florianhaar florianhaar florianhaar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: Flagged Messages not filtered per Chat
2 participants
@phranck @florianhaar