RoundedCornersTransformation can support 4 various sizes #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis build keeps failing. @colinrtwhite can you help to take a look |
coil-base/src/main/java/coil/transform/RoundedCornersTransformation.kt
Outdated
Show resolved
Hide resolved
| @@ -10,6 +10,7 @@ import androidx.lifecycle.Observer | |||
| import androidx.recyclerview.widget.RecyclerView | |||
| import androidx.recyclerview.widget.StaggeredGridLayoutManager | |||
| import coil.api.load | |||
| import coil.transform.RoundedCornersTransformation | |||
|
|
|||
| class MainActivity : AppCompatActivity() { | |||
There was a problem hiding this comment.
Please remove the changes to the sample app.
|
|
||
| init { | ||
| require(radius >= 0) { "Radius must be >= 0." } | ||
| require(radii.size == 1 || radii.size == 4) { "Radii size has to be either 1 or 4" } | ||
| require(radii.all { it >= 0 }) { "All radius must be >= 0." } |
There was a problem hiding this comment.
Nit: "All radii must be >= 0."
|
@khatv911 Try re-running the build again. Unfortunately, the Travis CI Android Emulator has been a bit flaky lately. |
|
make changes as reviewed. |
|
@khatv911 Thanks. Looks like |
|
@colinrtwhite thanks for the finding. I had a successful build now. |
colinrtwhite
approved these changes
Sep 17, 2019
colinrtwhite
approved these changes
Sep 17, 2019
colinrtwhite
pushed a commit
that referenced
this pull request
Oct 5, 2022
* RoundedCornersTransformation can support 4 various sizes in clockwise order * Fix lint issue * trigger a CI rebuild * code review changes * fix wrong corner order * remove reduntdant brace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoundedCornersTransformation's constructor can accept one single Float value (all corners are equal) or 4 Float values as 4 different rounded radii.