Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7.2 prefix install fails #20

Closed
stefanozampini opened this issue Mar 4, 2020 · 12 comments
Closed

2.7.2 prefix install fails #20

stefanozampini opened this issue Mar 4, 2020 · 12 comments

Comments

@stefanozampini
Copy link

I can successfully make and install the C/C++ library, but then, the install rule eventually fails when running make install in the swig directory and I get the error below (prefix is not propagated)
Also, I do not need the python wrappers, bu I do not see how I can disable it from configure

$ ./configure --prefix=someprefix --enable-shared --enable-sparse
$ make
$ make install
...
Making install in swig
gmake[4]: Entering directory '/home/szampini/Devel/jointinversion/pkgs/petsc/arch-joint/externalpackages/ADOL-C-2.7.2/ADOL-C/swig'
CXX=mpicxx /usr/bin/python setup.py install --prefix=/home/szampini/Devel/jointinversion/pkgs/petsc/arch-joint --only-swig
running install
running build
running build_lib
skipping build of ADOL-C
running build_ext
prefix =  /home/szampini/adolc_base
@awalther1
Copy link
Contributor

Hi, we had this problem with the releases 2.7.0 and 2.7.1. This should be fixed now.

@stefanozampini
Copy link
Author

This has not been fixed (tried today, still same error)

@stefanozampini
Copy link
Author

@awalther1

@awalther1 awalther1 reopened this May 22, 2020
@awalther1
Copy link
Contributor

Hi, we had an issue with the prefix that was fixed in 2.7.2. I thought this had solved also your problem. However, this seems not to be the case. We will now have a look at your specific problem.
Best regards

Andrea

@stefanozampini
Copy link
Author

https://github.com/coin-or/ADOL-C/blob/master/configure.ac#L663

it should be test and not $test

I tried with master and it works as expected. We should temporarily track the dev branch in our package and start using releases from the next one.
Anyway, it would be nice if you provide --enable-python as configure flag in the next releases to allow for users to disable the python build

@stefanozampini
Copy link
Author

Sorry, not yet completely fixed. I spoke too early. This is with the latest master

configure (note the libdir)

./configure --prefix=/home/szampini/Devel/petsc/arch-maint MAKE=/usr/bin/gmake --libdir=/home/szampini/Devel/petsc/arch-maint/lib CC="mpicc" CFLAGS="-g -O0 -fPIC" AR="/usr/bin/ar" ARFLAGS="cr" CXX="mpicxx" CXXFLAGS="-g -O0 -fPIC" F90="mpif90" F90FLAGS="-g -O0 -fPIC" FFLAGS="-g -O0 -fPIC" FC="mpif90" F77="mpif90" FCFLAGS="-g -O0 -fPIC" --enable-shared --enable-sparse

When running make install, the swig build uses the suffix lib64 as location for adolc (libdir is not respected) and fails.

...
compile options: '-I/usr/lib64/python3.7/site-packages/numpy/core/include -I/usr/include/python3.7m -I/home/szampini/Devel/petsc/arch-maint/include -c'
extra options: '-std=c++11 -fPIC -w'
gcc: adolc-python_wrap.cpp
mpicxx -pthread -shared -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -g build/temp.linux-x86_64-3.7/adolc-python_wrap.o -L/usr/lib64 -L/home/szampini/Devel/petsc/arch-maint/lib64 -Wl,--enable-new-dtags,-R/home/szampini/Devel/petsc/arch-maint/lib64 -ladolc -lpython3.7m -o build/lib.linux-x86_64-3.7/_adolc.cpython-37m-x86_64-linux-gnu.so
/usr/bin/ld: cannot find -ladolc
collect2: error: ld returned 1 exit status
error: Command "mpicxx -pthread -shared -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -g build/temp.linux-x86_64-3.7/adolc-python_wrap.o -L/usr/lib64 -L/home/szampini/Devel/petsc/arch-maint/lib64 -Wl,--enable-new-dtags,-R/home/szampini/Devel/petsc/arch-maint/lib64 -ladolc -lpython3.7m -o build/lib.linux-x86_64-3.7/_adolc.cpython-37m-x86_64-linux-gnu.so" failed with exit status 1

@awalther1
Copy link
Contributor

Hi, thanks a lot for the additional information. We will try to fix this as soon as possible.

@caidao22
Copy link

Hi, this issue has been hanging fire for over six months. Is there a plan for fixing it soon?

@awalther1
Copy link
Contributor

awalther1 commented Sep 22, 2020

Hi,

it should be test and not $test

this is fixed now in the master

--enable-python as configure flag

this is now provided, by default it is disabled, disabling also the swig build

we still have to fix the problem with the suffix lib64 as location for the swig build

It would be great if you could give it a try

@awalther1
Copy link
Contributor

awalther1 commented Sep 28, 2020

This should be really fixed now.

@stefanozampini
Copy link
Author

stefanozampini commented Sep 29, 2020

Thanks. However, it is not completely fixed, since you did not commit the new configure file. I had to rerun autoconf to have the python script disabled by default @awalther1

@awalther1
Copy link
Contributor

Thanks for the hint, I commited the corresponding configure file a few minutes ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants