-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme: Switch to Markdown, add a diagram #439
Conversation
Hi John, I attach a picture made some time ago for clarification So my proposal is to change the label for GUI components from 'Deprecated' to 'Legacy'. Regards |
Oh, so SoGtk/SoQt/SoWin/SoXt are part of Open Inventor API? But the core Coin library doesn't include them. Probably should add a note about that. |
That's fine for me. Coin / Open Inventor 'history':
Do not take this as 'gold' ... is just my uderstanding of the long - and glorious - Open Inventor history :) Cheers |
@ggabbiani done |
Hi Vanuan, This looks nice. Just a few comments:
So I'm not exactly sure whether this diagram increases or decreases the correct understanding of the coverage of the Coin3D suite of libraries. Giampiero's overview does not have this problem. Maybe it is worth extending this instead? Where is it currently included? Best regards, |
Also for diagrams in general, I'd like to see them use editable formats, so that they can easily be adjusted in the future. Would SVG work well? |
Regarding Giampiero's picture, I think it has a lot more details than a newbie might want to know. Newcomers are only expected to be familiar with OpenGL, GUI and language bindings. So only terms that are introduced in the diagram is Open Inventor API and its implementation. Giampiero's picture focuses more on the coverage of Open Inventor API by Coin version and the extended API it provides. That can be included as well but only as an elaboration of the Coin implementation and its dependencies.
SVG is great for scalability and consumption, but not so much for editing. I can export in SVG, but it would not be editable, as I didn't use SVG editor to create it. I used Figma. Do you want me to add you to the Figma project where I created this diagram? https://www.figma.com/file/MF5ULt44QAihMOh3cv4YoM/Content?node-id=17%3A0 I've incorporated your suggestions: |
bump |
Another point: a newby may conclude from this diagram that applications must interface with Coin through Python, which is not the case. The text under Diagrams like these can perfectly well be coded in SVG by hand, it is a programming language after all. On the other hand, the structure of Coin is not likely to change, so once we agree on a diagram then the format is not a big deal. I still think the diagram is not good, but I don't want to block this if other maintainers think it is a net benefit. If you split the port to Markdown into its own PR, I'll happily merge that. |
@veelo could you incorporate suggested modifications? You can either create figma account and make a copy or "well code it in SVG" I already removed C++ from language binding and now you request to bring it back. It's confusing. |
Sorry for the confusion, and for being a nag. As you requested: #444. |
Thanks for your efforts, your changes to readme.md were merged as part of #444. |
Thank you @Vanuan. It's a great improvement! |
Let's switch from *.txt to markdown and add some nice diagrams.