-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added modern style Doxygen Awesome documentation #63
Added modern style Doxygen Awesome documentation #63
Conversation
DOXYFILE_ENCODING = UTF-8 | ||
PROJECT_NAME = @PROJECT_NAME@ | ||
PROJECT_NUMBER = @PROJECT_VERSION@ | ||
PROJECT_BRIEF = A Coin3D Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The brief description has to be quoted, otherwise all whitespace is lost.
# Configuration options related to external references | ||
#--------------------------------------------------------------------------- | ||
TAGFILES = @DOXYGEN_TAGFILES@ | ||
GENERATE_TAGFILE = @CMAKE_BINARY_DIR@/html/@PROJECT_NAME@-@PROJECT_VERSION_MAJOR@.tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tag file has to be created in the html_awesome
directory, otherwise building both doc styles fails when running CMake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the awesome style. Thanks for the amazing work you did on the documentation. It is highly appreciated.
Hi Volker, I have a few more questions about your opinion on the integration of the new style:
So what is your opinion? Kind regards, Uwe |
Thanks Uwe, I would prefer linking to the specific library repo as the coin3d repo contains too many subrepos. Quarter is pinned but other repos are not. If we'd link the subrepo one could easily jump right to the source code of interest. As for the question whether to link the doxygen_awesome repo as submodule i tend to fork it and use the fork as submodule. That way the dependency is never broken and can be updated as needed. What do you think about this? Cheers, Volker |
Hi Volker, I completely agree with your proposal - this was also my idea and it is a clean solution. I updated the branch, to include doxygen-awesome as submodule and added a I also added some code to CMakeLists.txt to update the submodules during configuration to ensure that the documentation submodule is properly initialized. So it would be great, if you could fork the doxygen-awesome project to prepare the next steps. The next question is, where we add the
I would prefer option 2 because I do not really like ther complexity of a git submodule in a git submodule. But this is only a personal feeling so feel free to do it the way you like. So I would say:
|
Hi Uwe, thanks for your fantastic work on this PR. I just created the doxygen_awesome_css fork in the coin3d repository. You can adjust the submodule to it. The other questions/steps will be done this evening. Cheers, Volker |
Hi Volker, thank you for this quick response - great. I'm waiting until you have done the other steps this evening so that I can pick the right branch (coin3d) for the submodule. Thank you. |
Thanks Uwe, |
Hi Volker, If we include the doxygen-awesome style as a submodule, then we need to checkout a specific release branch (i.e. the latest release) - that means, we do not use master / main. If we have to check out a branch anyway, then it makes no difference whether it is a release branch or our coin3d branch. If we need to switch to another doygen-awesome release, because of new features or fixes, then we need to update all repositories that include the submodule to checkout the right branch / tag. If we us our coin3d branch, then we always know, that we have a working branch and we never need to update the other repos anymore. If we switch to a new doxygen-awesome release, then we only need to update our coin3d branch to the specific release. So I'm more for a coin3d branch in the submodule. And if we have our own branch, then it is easy to place a global working |
Hi Uwe, |
…oxygen-awesome project
…s sorting of class members
Hi Volker, Thank you for providing the doxygen-awesome fork with the coin3d branch. I updated this pull request to use this fork and I also did the following changes:
So I would say, this pull request is ready now from my point of view. |
Thanks Uwe, do you think we really need the default doxygen comments in the |
Sorry - I searched for this switch but could not find it - I just updated the file with a stripped version. |
Thanks for this valuable contribution to Coin3d development. Keep up the good work. |
The following pull request is meant as a proposal to add modern, responsive and mobile friendly style to Quarter library documentation that supports dark and light style. The doxygen style is based on the Doxygen Awesome project.
While the Coin3D libraries are up to date and usable with the latest Qt6 version, the documentation looks really old and outdated - like from the 90s. This gives the impression of an old and outdated project. Especially browsing the documentation on mobile devices is a pain.
If the pull request will be accepted after a discussion and some changes, I'm ready to update also the other coin libraries.
To avoid breaking the current documentation or the creation of CHM and QCH help files, I added a completely new build target documentation_awesome.