Add ability to define alternate URL in java websocket SDK #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(error handler): Adds the ability to handle error messages (coinapi#72)
Merge master
refresh fork
clean up thread when closing connection (coinapi#84)
|
Yes of course; I think we could just have url in the class; and handle the sandbox logic only inside the second controller where we just based on the boolean will fill up the url parameter. |
|
Awesome, I should have some time soon to that taken care of. Thanks! |
|
@Svisstack I updated the PR. Is something like this what you were thinking? |
Svisstack
pushed a commit
that referenced
this pull request
Mar 30, 2024
Svisstack
pushed a commit
that referenced
this pull request
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Svisstack would you be ok with something like this in the SDK?
If you are ok with it, I will clean up this PR.