This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

fix(asks): They were in wrong order. #112

Merged

fb55 merged 1 commit into coinbase:master from ThePrimeagen:ask-each

Sep 18, 2017

Contributor

ThePrimeagen commented Sep 18, 2017

Asks in 0.4.2 were using each but in this version they are using reach. Thus causing them to be backwards.


          fix(asks): They were in wrong order.

1ab1020

Contributor Author

ThePrimeagen commented Sep 18, 2017

A counter fix would be to insert with a different sorter. b > a instead of the current a > b

fb55 merged commit fda3e36 into coinbase:master

Contributor

fb55 commented Sep 18, 2017

Thanks a lot @michaelbpaulson!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet